Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

The phoneme needs to be converted to a list before being passed on. #2865

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

chrisveilleux
Copy link
Member

Description

Fixes an error where a phoneme is passed to the TTS engine as a string instead of a list of lists.

How to test

Execute a skill, like weather, multiple times in a row. If the same sentence is uttered, it is cached and the cache should work.

Contributor license agreement signed?

CLA [X]

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 18, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

Copy link
Contributor

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@krisgesling krisgesling merged commit 9c864de into dev Mar 18, 2021
@krisgesling krisgesling deleted the bugfix/phoneme-exception branch March 18, 2021 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants